make Meshes cheaply cloneable by using Arc<[T]> in iced_graphics::mesh::Indexed
#3070
+14
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…::mesh::Indexed`
Contributor
Author
|
Failing CI is from an upstream rustdoc change: rust-lang/rust#138907 |
|
This is great. We have ~25% performance increase by reusing the meshes! Hoping this gets merged soon! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have large meshes that I'd like to not have to recreate/clone every time I draw them. When using
wgpuI can use aiced_wgpu::geometry::Cache, however this doesn't work for other renderers. Since you can't query the renderer's type at runtime it makes sense to me to make reuse possible with this change.