Correcting several issues with NumberInput
#309
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rewrote the logic of
NumberInput
to solve issues #308, #304, #299 and the problem with included and excluded bounds.The
NumberInput
unlike theTypedInput
never allows invalid entries.People who try to implement a floating-point number should follow the way the
f32
is done; it can end with a.
I also added the support for any characters in the number, it just has to always be a valid number, regarding the
T::from_str
function.I merge
content_width
andwidth
. It seems to fix issues #286 and #278