Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting several issues with NumberInput #309

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

Ultraxime
Copy link
Contributor

I rewrote the logic of NumberInput to solve issues #308, #304, #299 and the problem with included and excluded bounds.

The NumberInput unlike the TypedInput never allows invalid entries.
People who try to implement a floating-point number should follow the way the f32 is done; it can end with a .

I also added the support for any characters in the number, it just has to always be a valid number, regarding the T::from_str function.

I merge content_width and width. It seems to fix issues #286 and #278

Copy link
Collaborator

@genusistimelord genusistimelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much! I looked over it and the changes look good.

@genusistimelord genusistimelord merged commit 7073768 into iced-rs:main Dec 3, 2024
2 checks passed
@Ultraxime
Copy link
Contributor Author

Normally I checked with the examples
And with one of my projects so it should be working
But I'm still waiting for feedback

@genusistimelord
Copy link
Collaborator

I will fully test them tomorrow to see if I can find anymore issues and let you know. Other than that the best thing I can also do is ask those who had issues to try the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants