Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#183 state remastering #185

Closed
wants to merge 10 commits into from
Closed

#183 state remastering #185

wants to merge 10 commits into from

Conversation

kramlex
Copy link
Contributor

@kramlex kramlex commented Jun 17, 2022

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Jun 17, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
4.0% 4.0% Duplication

@Alex009 Alex009 changed the base branch from master to develop July 6, 2022 10:51
@Alex009 Alex009 marked this pull request as draft July 6, 2022 10:51
@Alex009 Alex009 changed the title #183 state remastering DRAFT #183 state remastering Jul 6, 2022
@Alex009 Alex009 linked an issue Jul 6, 2022 that may be closed by this pull request
Split mvvm-state into components #183
Open
@Alex009
Copy link
Member

Alex009 commented Sep 25, 2022

@kramlex detekt fixes required. check CI runs

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kramlex kramlex requested a review from Alex009 September 26, 2022 03:43
@kramlex
Copy link
Contributor Author

kramlex commented Sep 26, 2022

@Alex009 I don't understand. With the use of TestRule in the commonMain source set, the build falls on ubuntu test, and without it it also falls. What to do?

Alex009
Alex009 requested changes Oct 31, 2022
View reviewed changes
Copy link
Member

@Alex009 Alex009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests fix required

mvvm-state-test/src/commonMain/kotlin/dev/icerock/moko/mvvm/test/livedata/LiveDataTest.kt
Comment on lines -16 to -17
@get:TestRule
val instantTaskExecutorRule = AndroidArchitectureInstantTaskExecutorRule()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rollback

@kramlex
Copy link
Contributor Author

kramlex commented Jan 11, 2023

work has resumed in a new merge request

@kramlex kramlex closed this Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex009 Alex009 Alex009 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split mvvm-state into components
2 participants
@kramlex @Alex009