Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Image Building #1

Merged
merged 8 commits into from
Oct 20, 2020
Merged

Setup Image Building #1

merged 8 commits into from
Oct 20, 2020

Conversation

salvis2
Copy link
Collaborator

@salvis2 salvis2 commented Oct 14, 2020

Set up image configuration and building for icesat2py/icepyx-gallery#1

@JessicaS11 here are the things I think need doing before trying this out:

  • Enter github secret DOCKER_USERNAME for this repo
  • Enter github secret DOCKER_PASSWORD for this repo
  • Decide on image name and DockerHub location for build-and-push-icepyx-image.yaml
  • Review package list in environment.yml and requirements.txt

@JessicaS11
Copy link
Member

I tried creating an icepyx organization, then realized what I needed was a login, but it hasn't yet freed up the icepyx username (even since the organization is deleted). I'm going to wait and see if it will work later today or tomorrow, otherwise I'll set something up with different names.

Will it work for me to just directly link icesat2py on GitHub and icepyx on Docker? Then I don't think we need to store the authentication info.

@salvis2
Copy link
Collaborator Author

salvis2 commented Oct 15, 2020

I tried creating an icepyx organization, then realized what I needed was a login

Right, at the end of the day all we need is a username and a password. You could use your own login as an approved maintainer of a DockerHub Icepyx organization, similar to how we had permission to push to uwhackweeks for the IceSat-2 Hackweek. You can also just make a standalone user and push to their images.

Will it work for me to just directly link icesat2py on GitHub and icepyx on Docker?

I am unsure. My two concerns are that I have not tried this before and I don't know how well the repo2docker functionality is setup in this workflow. I'm inclined to think that we need to use the current repo2docker GitHub Action because it's set up to track certain files that normal Docker builds might gloss over. That repo is also archived and the builds.md file has a lot of broken links, so I'm suspicious about it working without a lot of fiddling.

@JessicaS11
Copy link
Member

I created an icepyx account on Docker, so this repo now has a DOCKER_USERNAME and DOCKER_PASSWORD set. Do we also need to set up an organization on Docker so that there can be shared management of the image? Or can you just share what you set up?

@salvis2
Copy link
Collaborator Author

salvis2 commented Oct 20, 2020 via email

@salvis2
Copy link
Collaborator Author

salvis2 commented Oct 20, 2020

For clarity, I put a comment here: icesat2py/icepyx-gallery#1 (comment)

Per a suggestion by @scottyhq , I put in my own credentials and a place for an image to live under my username, and the build worked! https://github.com/salvis2/icepyx-examples-image/actions/runs/316625746

@JessicaS11 if you have credentials to put into the icepyx-gallery repo tomorrow, I'll use them to build the image and get to testing the gallery. I can test with my own image otherwise and we will just switch things later.

need to update with a link to the gallery later
@salvis2 salvis2 merged commit c591653 into icesat2py:main Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants