Skip to content

Commit

Permalink
feat: Add PHP 8.4 support
Browse files Browse the repository at this point in the history
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
nickvergessen committed Nov 8, 2024
1 parent 35b33f0 commit 8a6c8cd
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 5 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,8 @@ jobs:
- "8.0"
- "8.1"
- "8.2"
- "8.3"
- "8.4"

steps:
- name: krb5-dev
Expand Down
2 changes: 1 addition & 1 deletion src/Exception/Exception.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
* @psalm-consistent-constructor
*/
class Exception extends \Exception {
public function __construct(string $message = "", int $code = 0, Throwable $previous = null) {
public function __construct(string $message = "", int $code = 0, ?Throwable $previous = null) {
parent::__construct($message, $code, $previous);
}

Expand Down
2 changes: 1 addition & 1 deletion src/Exception/InvalidRequestException.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class InvalidRequestException extends Exception {
*/
protected $path;

public function __construct(string $path = "", int $code = 0, \Throwable $previous = null) {
public function __construct(string $path = "", int $code = 0, ?\Throwable $previous = null) {
$class = get_class($this);
$parts = explode('\\', $class);
$baseName = array_pop($parts);
Expand Down
6 changes: 3 additions & 3 deletions src/ServerFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ class ServerFactory {
* @param ITimeZoneProvider|null $timeZoneProvider
*/
public function __construct(
IOptions $options = null,
ISystem $system = null,
ITimeZoneProvider $timeZoneProvider = null
?IOptions $options = null,
?ISystem $system = null,
?ITimeZoneProvider $timeZoneProvider = null
) {
if (is_null($options)) {
$options = new Options();
Expand Down

0 comments on commit 8a6c8cd

Please sign in to comment.