HEIC to JPG image conversion

[cdraf]

I was inspired by the Initial work towards HEIC to JPG conversion and thought I could contribute. What I came up with is similar but does not require ImageMagick.

The initial PR, and subsequent commit (since squashed), triggered a git workflow that showed build errors for python3.9. It seems that there is no wheel but one is coming.

Also the build machine needs libheif-dev installed to pass the check_quality and validate_build. I don't know if adding an additional package to the build/user machine falls in line with what this project wants but I think the build will pass if it is installed.

[menkej]

Sorry for reacting so late, I'm really busy outside my open source dev work since a while (hope it will get better soon). Anyways:

Nice work! I could only have a quick look, so here are my initial thoughts: it adds another dependency to an external non python tool/lib, right? How do we make sure this still works on our currently supported platforms. There are users on Win/Mac and not only Linux relying on icloudpd. How could we handle this? It seems like you're sticking within docker at the moment. Have you tried other platforms?

[cdraf]

No problem, I completely understand.

I will have to test it out on the other platforms (mac/win). It may be that the required lib is bundled with the Python package but I'm just guessing. Am hoping to get some time in the next few weeks to check it out and see if there is a reasonable solution.

[cdraf]

get some time in the next few weeks

that did not happen lol

I've changed base.py to import heif_to_jpg only if the --convert-jpg argument is passed which makes the dependency on pyheif (and Pillow) optional, end users will only need the additional dependencies if they want to do image conversion.

To handle the Windows case I built and installed libheif using vcpkg and copied the libs and dlls to the venv which allows the pip install pyheif to succeed. I've added instructions to the README.

I don't have a mac so I am not able to confirm if any of this works.