add new thumbnail flag #336
Conversation
|
Thanks for your pull request! What is your usecase for this? Could you please also add testcases for it? |
framirez90
force-pushed
the
download-thumbnail
branch
from
c00dfa5
to
43facd9
Compare
|
Hi @menkej I want to retrieve only the photo as it shown on album cover on IOS device. I added a new TC for it. |
| runner = CliRunner(env={ | ||
| "CLIENT_ID": "DE309E26-942E-11E8-92F5-14109FE0B321" | ||
| }) | ||
| result = runner.invoke( |
There was a problem hiding this comment.
You are running the script but don't have any assertions/tests. I suggest checking for the pictures you are expecting to be downloaded. Additionally you should do a negative test, p.e. run without your new parameter (so that more pictures are downloaded) and check that the second picture that would come is not been downloaded when run with --thumbnail.
| shutil.rmtree(base_dir) | ||
| os.makedirs(base_dir) | ||
|
|
||
| with vcr.use_cassette("tests/vcr_cassettes/listing_photos.yml"): |
There was a problem hiding this comment.
Best would be to add a new cassette for this test case. Creating a new cassette is pretty easy. Just use a new filename and run the test again. Make sure to remove personal data from the cassette before you check in.
| @@ -52,6 +52,9 @@ Options: | |||
| Download live photos) | |||
| --force-size Only download the requested size (default: | |||
| download original if size is not available) | |||
| --thumbnail Only download the first photo as thumbnail | |||
| of album as it is shown in the device | |||
| (-a, --album option is required) | |||
I added a new feature to only be able download the first photo of certain album as as it shown on the device.