fix unittests and run them in gh-actions #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiaselhans
force-pushed
the
unittests
branch
2 times, most recently
from
797167a
to
49984cc
Compare
|
i would like to push this topic again. Most lines are formatting issues, if you are not fine with those changes please let me know and i can reduce this pr to the minimum. |
|
@martinleblanc can i get your feedback on this? Tests are failing in the current master. i fixed the tests and automated testing might help to reduce your workload. |
|
I am currently packing pyvat in an RPM for Fedora. It would be great if we can run tests without |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a new take on #43