Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved signature lookup #851

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

notabene2
Copy link

Caching the part of the stream which potentially contains the signature improves the performance in case of streams where seeking backwards is costly. If the underlying stream is for example an Azure blob stream which pretends to contain a zip file but actually does not then the lookup took several minutes to figure this out.

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

Caching the part of the stream which potentially contains the signature
improves the performance in case of streams where seeking backwards is costly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant