Ensure unique schedule #1049
Open
Ensure unique schedule #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicksey
changed the title
|
I take that this is ready for review. Can you add the issue that you're closing in the "Issues" section of the PR? Also, please add a brief test plan for how the reviewer would confirm that your change does what it's supposed to do and probably doesn't break anything. |
Merged
MinhxNguyen7
requested changes
Dec 22, 2024
| label="Name" | ||
| onChange={handleNameChange} | ||
| value={name} | ||
| error={!!errorMessage} |
There was a problem hiding this comment.
Please use Boolean instead of !!. That's less explicit and quite weird to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure unique schedule names when adding and renaming.
Test Plan
Try to add a new schedule with a name that already exists.
Try to rename a schedule to a name that already exists.
Both shouldn't work.
Issues
Unique schedule names.
Closes #1032