Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor weekly job to just run event job once #469

Merged
merged 1 commit into from
Feb 2, 2025
Merged

refactor weekly job to just run event job once #469

merged 1 commit into from
Feb 2, 2025

Conversation

dlustre
Copy link
Collaborator

@dlustre dlustre commented Feb 1, 2025

Summary

also just simplifies the weekly cronjob into a function call

Changes

  • refactor weekly job to just run event job once
  • add weekly test

Verification

  • passes manual test, events show up in client. automated test doesn't work, runs too slow (the queries become transactional so it slows down)

@dlustre
* add weekly api test
a708018 
* refactor weekly job to just run event job once
@dlustre dlustre added enhancement New feature or request backend labels Feb 1, 2025
@dlustre dlustre requested a review from bjsilva1 February 1, 2025 18:46
bjsilva1
bjsilva1 approved these changes Feb 2, 2025
View reviewed changes
Copy link
Collaborator

@bjsilva1 bjsilva1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, everything works on my end 👍. I do see that the test takes way to long to run, will make into its own issue.

@bjsilva1 bjsilva1 merged commit 3304475 into main Feb 2, 2025
1 check passed
@dlustre dlustre deleted the refactor-weekly branch February 2, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjsilva1 bjsilva1 bjsilva1 approved these changes

Assignees
No one assigned
Labels
backend enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlustre @bjsilva1