Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ZotMeet logo to the nav bar and made it the website icon #141

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added ZotMeet logo to the nav bar and made it the website icon #141

wants to merge 3 commits into from

Conversation

amhaiskar0921
Copy link
Contributor

@amhaiskar0921 amhaiskar0921 commented Jan 21, 2025 •
edited
Loading

Summary

  1. Added the ZotMeet logo to the nav bar, replacing the command sign
image
  1. Changed the tab icon from the default globe to the ZotMeet logo in black by changing the favicon.ico file to contain the ZotMeet logo
    image

closes #137

@amhaiskar0921 amhaiskar0921 self-assigned this Jan 21, 2025
@amhaiskar0921 amhaiskar0921 linked an issue Jan 21, 2025 that may be closed by this pull request
Add Logo to the sidebar #137
Open
seancfong
seancfong requested changes Jan 21, 2025
View reviewed changes
Copy link
Member

@seancfong seancfong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just left a couple of styling changes to try and a little bit of cleanup.

src/components/nav/app-nav.tsx Outdated Show resolved Hide resolved
src/components/nav/app-nav.tsx Outdated Show resolved Hide resolved
@amhaiskar0921 amhaiskar0921 requested review from seancfong and removed request for KevinWu098 January 23, 2025 17:02
@seancfong seancfong requested a review from aizilerts January 23, 2025 17:49
aizilerts
aizilerts reviewed Jan 27, 2025
View reviewed changes
Copy link

@aizilerts aizilerts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nothing from me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seancfong seancfong seancfong requested changes

@aizilerts aizilerts aizilerts left review comments

Requested changes must be addressed to merge this pull request.

Assignees

@seancfong seancfong

@aizilerts aizilerts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Logo to the sidebar
3 participants
@amhaiskar0921 @seancfong @aizilerts