-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve empty enrollment history entries #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waterkimchi
changed the title
Fix: Resolve empty enrollment history entries #31
Fix issue #31: Resolve empty enrollment history entries
Jan 6, 2025
andrew-wang0
changed the title
Fix issue #31: Resolve empty enrollment history entries
fix: resolve empty enrollment history entries
Jan 8, 2025
andrew-wang0
requested changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just a few syntactic changes and it should be good to go 🫡
andrew-wang0
reviewed
Jan 8, 2025
waterkimchi
had a problem deploying
to
staging-64
January 9, 2025 02:33 — with
GitHub Actions
Failure
waterkimchi
had a problem deploying
to
staging-64
January 9, 2025 02:36 — with
GitHub Actions
Failure
waterkimchi
had a problem deploying
to
staging-64
January 9, 2025 06:53 — with
GitHub Actions
Failure
waterkimchi
had a problem deploying
to
staging-64
January 9, 2025 17:36 — with
GitHub Actions
Failure
andrew-wang0
force-pushed
the
fix-issue-31
branch
from
January 9, 2025 18:08
f4552bb
to
018c221
Compare
andrew-wang0
had a problem deploying
to
staging-64
January 9, 2025 18:08 — with
GitHub Actions
Failure
waterkimchi
had a problem deploying
to
staging-64
January 15, 2025 20:00 — with
GitHub Actions
Failure
waterkimchi
had a problem deploying
to
staging-64
January 15, 2025 20:04 — with
GitHub Actions
Failure
andrew-wang0
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the issue where the enrollment history endpoint was returning entries for terms without enrollment data. Now, the endpoint only returns entries for terms with actual enrollment data, ensuring that each entry has at least one data point.
Related Issue
This pull request addresses issue #31.
Motivation and Context
This change is required to prevent unintentional behavior in consumers of the enrollment history endpoint. By ensuring that only terms with enrollment data are returned, we avoid empty data arrays that could cause issues or unexpected behavior in downstream applications.
How Has This Been Tested?
Tested on a local deployment by using the pnpm environment. Minor changes. None affects other code.
Screenshots (if appropriate):
Before(includes the empty data sections):
After(removed the empty data sections):
Types of changes
Checklist: