Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeterPortal Getting Started #8

Merged
merged 5 commits into from
Apr 1, 2024
Merged

PeterPortal Getting Started #8

merged 5 commits into from
Apr 1, 2024

Conversation

danielbolee
Copy link
Contributor

Add Getting Started information in required format

For issue #5

@danielbolee danielbolee self-assigned this Feb 22, 2024
@danielbolee danielbolee requested a review from a team as a code owner February 22, 2024 01:05
@danielbolee danielbolee temporarily deployed to Staging \#8 February 22, 2024 01:05 — with GitHub Actions Inactive
@danielbolee danielbolee temporarily deployed to Staging \#8 February 22, 2024 07:26 — with GitHub Actions Inactive
@js0mmer js0mmer linked an issue Feb 22, 2024 that may be closed by this pull request
Copy link
Member

@js0mmer js0mmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple small suggestions.

pages/peterportal/getting-started.mdx Outdated Show resolved Hide resolved
pages/peterportal/getting-started.mdx Outdated Show resolved Hide resolved
@danielbolee danielbolee temporarily deployed to Staging \#8 February 29, 2024 02:49 — with GitHub Actions Inactive
@danielbolee danielbolee temporarily deployed to Staging \#8 February 29, 2024 02:56 — with GitHub Actions Inactive
Copy link
Member

@js0mmer js0mmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick but spacing before/after code blocks is inconsistent

e.g.
image

pages/peterportal/getting-started.mdx Outdated Show resolved Hide resolved
@danielbolee danielbolee temporarily deployed to Staging \#8 March 4, 2024 03:59 — with GitHub Actions Inactive
@danielbolee danielbolee temporarily deployed to Staging \#8 March 13, 2024 20:27 — with GitHub Actions Inactive
Copy link
Member

@js0mmer js0mmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexanderl19
Copy link
Member

Just noticed that branch protections are blocking this PR. Not sure why that's the case, but I'll merge this PR right now and investigate further.

@alexanderl19 alexanderl19 merged commit 190b65f into main Apr 1, 2024
2 checks passed
@alexanderl19 alexanderl19 deleted the PeterPortal branch April 1, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PeterPortal Getting Started Docs
3 participants