Fix deploy workflow concurrency (#525)

icssc · Dec 7, 2024 · 7113666 · 7113666
1 parent 54ef476
commit 7113666
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/.github/workflows/build-and-deploy.yml b/.github/workflows/build-and-deploy.yml
@@ -10,9 +10,9 @@ on:
       - reopened
       - synchronize
 
+# do not cancel in progress, SST will be stuck in a "locked" state if cancelled mid-deployment
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
-  cancel-in-progress: true
 
 jobs:
   build_and_deploy:

diff --git a/.github/workflows/clean-up-pr.yml b/.github/workflows/clean-up-pr.yml
@@ -4,6 +4,7 @@ on:
   pull_request:
     types: [closed]
 
+# use pr number for group instead of github.ref because ref will be main branch when the PR closes which is not a unique group for the PR
 concurrency:
   group: ${{ github.workflow }}-pr-${{ github.event.pull_request.number }}
   cancel-in-progress: true