Make add and edit year a modal #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating name, year, and quarters works; but quarter state is not loaded properly yet
Matches the Figma design
|
Fixes #252 |
js0mmer
requested changes
Feb 10, 2024
Update branch
4 tasks
js0mmer
requested changes
Feb 14, 2024
js0mmer
reviewed
Feb 14, 2024
Merge 'master' into 'year-modal'
|
Alright, addressed the remaining comments. Let me know if there's anything else you'd like me to change. |
js0mmer
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
LGTM! I left a small suggestion on refactoring/renaming variables in the quarterValues function. I will go ahead and give you the approval and leave that up to you if you want to implement (I think the suggested variable names make it a little clearer).
edit: breaking issue with usage of 'summer 1'/'summer 2' instead of 'summer I'/'summer II'
Co-authored-by: Jacob Sommer <[email protected]>
|
Deployed staging instance to https://staging-419.peterportal.org |
|
Testing locally, this still seems to work with editing quarters. @js0mmer I think it'd be good if you verify on staging real quick then if it does go ahead and merge it for me. |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When you click the "add year" or "edit year" buttons, there will now be a modal window to add/edit details instead of a floating popover. it also combines "add quarter" and "edit year" functionalities into the same menu and allows you to add or remove several years at once a bit faster.
Because this makes changes to the edit year menu, I have also made that use an OverlayTrigger like the add year was previously.
Screenshots
BEFORE:
AFTER:
Steps to verify/test this change:
Final Checks:
Issues
Closes #398