Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust appearance of course hit #495

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Adjust appearance of course hit #495

merged 1 commit into from
Oct 30, 2024

Conversation

Awesome-E
Copy link
Member

@Awesome-E Awesome-E commented Oct 30, 2024

Description

Tweaks the appearance of course hits so the titles look nicer and the tags follow our site's theming

This also fixes the issue with the last PR where light mode would cause the text inside professor name icons to be black

I'm not super satisfied with the end result, but I do think it is a step up. I think the problem is there's still a mental load when trying to differentiate between the course title and the department. We could experiment with changing the color of the subtitle at some point.

Another consideration could be to remove the subtitle entirely and just show that in the full course page, since which school a class is in is usually the same as the course title. (I know cross-listings are where this might be useful, but to me that sounds like something you'd want to know only if you're interested in it, and therefore click into the full page)

Screenshots

Before:
image

After:
image

Steps to verify/test this change:

  • Verify changes work as expected on staging instance

Final Checks:

  • Verify successful deployment

This also fixes the issue with the last PR where light mode would cause the text inside professor name icons to be black
@Awesome-E Awesome-E temporarily deployed to staging-495 October 30, 2024 15:30 — with GitHub Actions Inactive
@Awesome-E Awesome-E requested a review from js0mmer October 30, 2024 15:34
Copy link
Member

@js0mmer js0mmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Awesome-E Awesome-E merged commit 9ddce4c into master Oct 30, 2024
2 checks passed
@Awesome-E Awesome-E deleted the course-styles branch October 30, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants