Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash with no planners saved to account #503

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Conversation

js0mmer
Copy link
Member

@js0mmer js0mmer commented Nov 8, 2024

Description

  • Roadmap page would crash for new users who have no roadmap saved to their account
  • adjusted return type of the roadmap route to be undefined when there are no saved planners, frontend code expects undefined to be returned if the user has no saved roadmap
    • was previously returning object with empty arrays of planners, transfers, and undefined timestamp
  • fixed another issue where you couldn't save to your account with no transferred courses
  • fixed import transcript crash due to different quarter name
  • convert any legacy local roadmaps to current data format to prevent any possible crashes there

Steps to verify/test this change:

  • Verify changes work as expected on staging instance

Final Checks:

  • Verify successful deployment

(optional)

  • Write tests
  • Write documentation

Issues

Closes #502

@js0mmer js0mmer temporarily deployed to staging-503 November 8, 2024 21:06 — with GitHub Actions Inactive
@js0mmer js0mmer requested a review from Awesome-E November 8, 2024 21:13
@js0mmer js0mmer temporarily deployed to staging-503 November 10, 2024 23:18 — with GitHub Actions Inactive
@js0mmer js0mmer temporarily deployed to staging-503 November 10, 2024 23:31 — with GitHub Actions Inactive
@js0mmer js0mmer temporarily deployed to staging-503 November 10, 2024 23:54 — with GitHub Actions Inactive
@js0mmer js0mmer mentioned this pull request Nov 11, 2024
5 tasks
@js0mmer js0mmer temporarily deployed to staging-503 November 11, 2024 03:27 — with GitHub Actions Inactive
@js0mmer js0mmer temporarily deployed to staging-503 November 13, 2024 22:38 — with GitHub Actions Inactive
@js0mmer js0mmer merged commit f0a6511 into main Nov 13, 2024
2 checks passed
@js0mmer js0mmer deleted the fix-roadmap-crash branch November 13, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PeterPortal Roadmap showing a black screen after logging in
2 participants