Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix search page crash #530

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Fix search page crash #530

merged 3 commits into from
Dec 9, 2024

Conversation

js0mmer
Copy link
Member

@js0mmer js0mmer commented Dec 7, 2024

Description

  • Updated conditions in GradeDist to make sure gradeDistData is not undefined
  • Removed use of non-null assertions in state initializations for better type safety

Steps to verify/test this change:

  • Verify changes work as expected on staging instance

Final Checks:

  • Verify successful deployment

(optional)

  • Write tests
  • Write documentation

Issues

Closes #529

@js0mmer js0mmer requested a review from Awesome-E December 7, 2024 02:28
@js0mmer js0mmer temporarily deployed to staging-530 December 7, 2024 02:28 — with GitHub Actions Inactive
Awesome-E
Awesome-E approved these changes Dec 9, 2024
View reviewed changes
site/src/component/GradeDist/GradeDist.tsx Outdated Show resolved Hide resolved
@js0mmer js0mmer temporarily deployed to staging-530 December 9, 2024 22:15 — with GitHub Actions Inactive
@js0mmer js0mmer temporarily deployed to staging-530 December 9, 2024 22:18 — with GitHub Actions Inactive
@Awesome-E
Copy link
Member

LGTM!

@js0mmer js0mmer merged commit fda540a into main Dec 9, 2024
2 checks passed
@js0mmer js0mmer deleted the fix-search-crash branch December 9, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Awesome-E Awesome-E Awesome-E approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page crash when switching between course/professor popup results
2 participants
@js0mmer @Awesome-E