Change tick size for charts #533
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always 6 ticks, each tick size is calculated as the max table value divided by 6.
Awesome-E
requested changes
Dec 9, 2024
There was a problem hiding this comment.
This is an example .env file that shows contributors the names of variables that should be used. It should not be deleted from the repository
There was a problem hiding this comment.
It looks like you installed pnpm locally (in this project) instead of globally. pnpm is used as a global package manager, so it should be installed with npm i -g pnpm rather than within the project. You should revert the changes to this file in the PR
There was a problem hiding this comment.
Same comment with package.json
| @@ -153,7 +156,7 @@ export default class Chart extends React.Component<ChartProps> { | |||
| legendOffset: 36, | |||
| }} | |||
| axisLeft={{ | |||
| tickValues: Array.from({ length: greatestCount }, (_, i) => i + 1), // integers from 1 to max | |||
| tickValues: Array.from({ length: greatestCount / tickSize }, (_, i) => i * tickSize + tickSize), // integers from 1 to max | |||
There was a problem hiding this comment.
Change or remove the out-of-date comment
Suggested change
| tickValues: Array.from({ length: greatestCount / tickSize }, (_, i) => i * tickSize + tickSize), // integers from 1 to max | |
| tickValues: Array.from({ length: greatestCount / tickSize }, (_, i) => i * tickSize + tickSize), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Always 6 ticks, each tick size is calculated as the max table value divided by 6.
Screenshots
Begin:
End:
Steps to verify/test this change:
Look at chart for class availabilities
Final Checks:
Yes, I did
Issues
None
Closes #