Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip and chart styling fixes #535

Merged
merged 11 commits into from
Jan 14, 2025
Merged

Tooltip and chart styling fixes #535

merged 11 commits into from
Jan 14, 2025

Conversation

ellisl10
Copy link
Contributor

@ellisl10 ellisl10 commented Dec 7, 2024 •
edited
Loading

Tooltip and chart styling fixes

Description

Moved color constants and tooltip dimensions/styling to separate files and made dimensions the same.

Screenshots

Before
Screenshot 2024-12-09 at 8 04 34 PM

After
Screenshot 2025-01-01 at 6 17 56 PM

Steps to verify/test this change:

  • Verify changes work as expected on staging instance

Final Checks:

  • Verify successful deployment

(optional)

  • Write tests
  • Write documentation

Issues

Closes #

@ellisl10 ellisl10 temporarily deployed to staging-535 December 7, 2024 03:25 — with GitHub Actions Inactive
@ellisl10 ellisl10 temporarily deployed to staging-535 December 7, 2024 03:32 — with GitHub Actions Inactive
@ellisl10 ellisl10 temporarily deployed to staging-535 December 10, 2024 04:01 — with GitHub Actions Inactive
@ellisl10 ellisl10 marked this pull request as ready for review December 10, 2024 04:05
@Awesome-E Awesome-E linked an issue Dec 11, 2024 that may be closed by this pull request
Chart / Pie Grade Distributions Styling Fixes #292
Closed
Awesome-E
Awesome-E requested changes Dec 11, 2024
View reviewed changes
api/.env.example Outdated Show resolved Hide resolved
site/src/component/GradeDist/Pie.tsx Show resolved Hide resolved
site/src/component/GradeDist/Pie.tsx Outdated Show resolved Hide resolved
site/src/component/GradeDist/Colors.tsx Outdated Show resolved Hide resolved
site/src/component/GradeDist/TooltipStyle.tsx Outdated Show resolved Hide resolved
@ellisl10 ellisl10 temporarily deployed to staging-535 January 2, 2025 02:00 — with GitHub Actions Inactive
@ellisl10 ellisl10 temporarily deployed to staging-535 January 2, 2025 02:15 — with GitHub Actions Inactive
@ellisl10 ellisl10 requested a review from Awesome-E January 2, 2025 02:15
Awesome-E
Awesome-E reviewed Jan 6, 2025
View reviewed changes
site/src/component/GradeDist/Chart.tsx Show resolved Hide resolved
site/src/component/GradeDist/colors.ts Outdated Show resolved Hide resolved
site/src/component/PrereqTree/PrereqTree.tsx Outdated Show resolved Hide resolved
site/src/component/SideInfo/SideInfo.tsx Outdated Show resolved Hide resolved
api/.env.example Outdated Show resolved Hide resolved
@ellisl10 ellisl10 temporarily deployed to staging-535 January 13, 2025 15:15 — with GitHub Actions Inactive
@ellisl10 ellisl10 force-pushed the Grade-Dist-Styling-Fixes branch from aa641b4 to f863e1a Compare January 13, 2025 15:36
@ellisl10 ellisl10 temporarily deployed to staging-535 January 13, 2025 15:36 — with GitHub Actions Inactive
@ellisl10 ellisl10 temporarily deployed to staging-535 January 13, 2025 15:37 — with GitHub Actions Inactive
@ellisl10 ellisl10 force-pushed the Grade-Dist-Styling-Fixes branch from 05695b2 to f863e1a Compare January 13, 2025 15:41
@ellisl10 ellisl10 temporarily deployed to staging-535 January 13, 2025 15:41 — with GitHub Actions Inactive
@ellisl10 ellisl10 temporarily deployed to staging-535 January 13, 2025 15:55 — with GitHub Actions Inactive
Awesome-E
Awesome-E approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@Awesome-E Awesome-E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might have some auto-format settings going wrong – code changes look good but we do need to get the lint check passing.

I think it's just site/src/component/PrereqTree/PrereqTree.tsx though

@Awesome-E Awesome-E temporarily deployed to staging-535 January 13, 2025 22:36 — with GitHub Actions Inactive
@Awesome-E
Copy link
Member

Just ran pnpm lint to find the problematic lint files, then npx prettier **/*.tsx --write to fix them, then committed them. Should be good to go!

@Awesome-E Awesome-E temporarily deployed to staging-535 January 13, 2025 22:37 — with GitHub Actions Inactive
@ellisl10 ellisl10 temporarily deployed to staging-535 January 14, 2025 02:32 — with GitHub Actions Inactive
@ellisl10 ellisl10 merged commit ee83a46 into main Jan 14, 2025
2 checks passed
@ellisl10 ellisl10 deleted the Grade-Dist-Styling-Fixes branch January 14, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Awesome-E Awesome-E Awesome-E approved these changes

@js0mmer js0mmer Awaiting requested review from js0mmer

@ethank2222 ethank2222 Awaiting requested review from ethank2222

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chart / Pie Grade Distributions Styling Fixes
2 participants
@ellisl10 @Awesome-E