Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle transfer credits #536

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Restyle transfer credits #536

wants to merge 9 commits into from

Conversation

CadenLee2
Copy link

@CadenLee2 CadenLee2 commented Dec 7, 2024

Restyle the Transfer Credits modal (under Roadmap page)

Description

  • Make the modal conform to ppc-modal (ex. the edit year modal)
  • Make the font size for p smaller when inside a transfer-modal
  • Make the units column smaller
  • Remove the unnecessary Close button (the X still exists in the corner)
  • Move and restyle the Add Entry button, which does not match the buttons on the other modals because it serves a different purpose (working with the form rather than confirming changes)
  • Locally test functionality still works (continues to count units when courses are added with units, allow adding/removing entries, closing the modal, changing the unit counts with up/down arrows) (tested on Firefox, should work elsewhere)
  • Locally test appearance on light/dark mode, on phone, on small screen, and with many transfer courses added (inner scroll bar)

Screenshots

Steps to verify/test this change:

  • Verify changes work as expected on staging instance

Final Checks:

  • Verify successful deployment

(optional)

  • Write tests
  • Write documentation

Issues

Closes #517

@Awesome-E
Copy link
Member

If you want to style that button specifically a little bit more, you can do this so that the plus is aligned and the button is slightly more pronounced:

  display: flex;
  align-items: center;
  gap: 4px;
  font-weight: bold;

Before (left) and after (right):

Copy link
Member

@Awesome-E Awesome-E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, just a couple things

  • See above comment about styling
  • You opened the PR but didn't set two reviewers. Make sure to set me as one reviewer and one other individual contributor as a second reviewer.

@CadenLee2 CadenLee2 requested a review from philosolog December 9, 2024 22:37
@Awesome-E
Copy link
Member

Looks a bit better now, but just one more thing to check – is the input font size at least 16px? When I tap the field on iOS, it zooms the entire page, which usually means that the font size is less than that size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restyle transfer credits modal to conform to rest of modals
3 participants