Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Professor Name Overflow #544

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Fix Professor Name Overflow #544

merged 2 commits into from
Jan 6, 2025

Conversation

vinnyho
Copy link
Contributor

@vinnyho vinnyho commented Dec 31, 2024

Description

  • Applied conditional logic to truncate long first names or last names using ellipses while maintaining spacing.
  • Ensured that names with reasonable lengths display fully without truncation.
  • Added hover tooltips to show the full name in cases where truncation occurs.
  • Updated CSS to handle overflow scenarios dynamically without altering the font size or overall layout.

Screenshots

Before:

After:

Test Plan

  • Verified that shorter name lengths display without truncation or layout issues.
  • Tested with long names to confirm truncation and proper tooltip display.
  • Ensured hover functionality and links work as expected.

Possible Problems

  • Using em as spacing might cause issues in certain layouts or resolutions. Please verify if this approach aligns with the design requirements.

Issues

Closes #537

Copy link
Member

@Awesome-E Awesome-E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@js0mmer
Copy link
Member

js0mmer commented Jan 3, 2025

@Awesome-E btw, open-source contributors can't merge

@Awesome-E Awesome-E merged commit 159a57b into icssc:main Jan 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Professor names can overflow in current instructors carousel
3 participants