Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

couplingXCubHandMk5: handle the param parsing with the YARP param parser generator #231

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

Nicogene
Copy link
Member

@Nicogene Nicogene commented Mar 26, 2024

This PR introduces the usage of the new YARP param parsing generator, moreover using this new tool allows to align this device to the good practice of avoiding using the findGroup clause for parsing the lists, see:

Unfortunately some parameters are "shared" with the gazebo controlboards so using () for this device breaks the parsing of the gazebo controlboards, so I would put thi on hold until we do not make the change also on gyp side (cc @traversaro)

Moreover maybe it is better that YARP 3.10 has been released

@traversaro
Copy link
Member

Moreover maybe it is better that YARP 3.10 has been released

Yes, that would be great. It would be problematic for people working on ergocub+gz-sim integration (@xela-95) if we could not release ergocub models until YARP 3.10 is released.

@Nicogene Nicogene force-pushed the couplingMk5ParamParser branch from 4ab49aa to bcfdd68 Compare April 8, 2024 14:41
@Nicogene Nicogene marked this pull request as ready for review April 8, 2024 14:41
@Nicogene
Copy link
Member Author

Nicogene commented Apr 8, 2024

I have also ported all the ini in order to use the parenthesis, with this patch:

It works fine, @traversaro probably it would be convenient to have another gyp tag

@Nicogene
Copy link
Member Author

YARP 3.10.0 has been released:

Probably I would need that the conda binaries are released too.

cc @traversaro

@traversaro
Copy link
Member

Probably I would need that the conda binaries are released too.

Ack! See conda-forge/yarp-feedstock#53 . I think I can do that even before robotology/robotology-superbuild#1740, as people using conda/pixi can easily pin yarp to an earlier release, and actually release it can help in testing it.

@Nicogene Nicogene force-pushed the couplingMk5ParamParser branch from bcfdd68 to fb32871 Compare November 27, 2024 11:17
@Nicogene Nicogene merged commit c69526d into master Dec 16, 2024
4 checks passed
@Nicogene Nicogene deleted the couplingMk5ParamParser branch December 16, 2024 11:45
@Nicogene
Copy link
Member Author

Finally the CI is green! Merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

couplingXCubHandMk5 – Refactor the param parsing for using yarpDeviceParamParserGenerator
2 participants