Fixed geometry Tree with actual type enforcement #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicahGale
added
the
bugs
…icts." This reverts commit d0f5f9d. -This was a hacky workaround for the real problem that was just solved
…de-is-showing-up-again
…de-is-showing-up-again
Pull Request Test Coverage Report for Build 8159078927Details
💛 - Coveralls |
…de-is-showing-up-again
MicahGale
deleted the
351-lack-of-data-enforcement-in-syntax-node-is-showing-up-again
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error here was that a syntax tree was being passed an invalid data type, and it was mostly hobbling along. So I enforced the data types and then actually fixed the data type issue.
fixes #351.