Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mat redesign #507

Draft
wants to merge 158 commits into
base: alpha-test
Choose a base branch
from
Draft

Mat redesign #507

wants to merge 158 commits into from
+2,099 −1,152

Conversation

MicahGale
Copy link
Collaborator

@MicahGale MicahGale commented Aug 25, 2024 •
edited
Loading

Description

Please include a summary of the change and which issue is fixed if applicable. Please also include relevant motivation and context.

Design based on #475.

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Implement alpha deploy process to PyPI in GHA
  • Test that Element and Nucleus? are immutable.
  • Added versionadded and versionchanged
  • Test unruly strings for material printing
  • test set like behavior for numberedobject collection
  • promote surfaces to be second or first class objects.
  • test materials with plib intermixed with materials
  • document migration.
  • Create easy way to edit existing Nuclide definition (library), and fraction.
  • Document all random constant dictionaries in dev stuff, and add to PR checklist
  • Implement all proposed changes from RFI: Overhauling how Materials and Isotopes are handled. #475.

MicahGale and others added 30 commits August 10, 2024 20:52
@MicahGale
Made a universal name parser re.
ef64a35
@MicahGale
Started making universal isotope parser.
457c59a
@MicahGale
Correctly implemented string based fancy names for isotopes.
f5990cb
@MicahGale
Wrote test cases to verify fancy names.
e0b7b95
@MicahGale
Added even more tests.
98a4ddc
@MicahGale
Handled the case of using a tuple as an isotope identifier.
4b72c02
@MicahGale
Prototyped the how get/set should work for materials.
5b9dac6
@MicahGale
Fixed typo not making callable.
c11a632
@MicahGale
Made it possible to get material component by just an Isotope.
e405498
@MicahGale
Made wrapper class for isotope library.
935c96e
@MicahGale
Merge branch 'develop' into mat_redesign
7e7e5ea
@MicahGale
Played around with changing setattr
a9c6f2f
@MicahGale
Added attribute error exception.
d868dcf
@MicahGale
Merge branch 'develop' into mat_redesign
c316de2
@MicahGale
Merge branch 'develop' into mat_redesign
e476eec
@MicahGale
Changed test_material to pytest.
6274878
@MicahGale
Fixed typo in test due to unindent.
ba7c366
@MicahGale
Harmonized isotope with upstream changes to ensure default values are…
11bbd37 
… set and handled.
@MicahGale
Updated isotope str for library being a wrapper object.
7eecfe1
@MicahGale
Started implement isotope slicing.
dcb50f3
@MicahGale
Wrote test case for library slicing.
302400f
@MicahGale
Started test get/setitem for material.
2cc9750
@MicahGale
Updated fancy_name to accept just an element outside a tuple.
360c2d5
@MicahGale
Made isotope library use meta-programming.
3763a52
@MicahGale
Ensure _is_atom_franction always set.
78090fe
@MicahGale
Fixing bugs with get/setitem.
d88ceeb
@MicahGale
Another fix.
ac34dc3
@MicahGale
Avoided trying to look for non-existant isotopes.
f7567fc
@MicahGale
Removed magic number from Isotopes.
4910729
@MicahGale
Changed default meta_state to 0 from None.
43bbdd2
@MicahGale MicahGale mentioned this pull request Oct 24, 2024
Open
@MicahGale
Copy link
Collaborator Author

Can we remove some old versionchanged and versionadded that were added in 0.2.0? I think at least the changes are old enough that they can be treated as the status quoue with 1.0.0

@MicahGale MicahGale added this to the 1.0.0-alpha milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MicahGale MicahGale

Labels
alpha testing Issues that came up during alpha testing bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". code improvement A feature request that will improve the software and its maintainability, but be invisible to users. feature request An issue that improves the user interface. parsers are hard Examples of where MCNP syntax is complicated and should be simplified.
Projects
None yet
Milestone
1.0.0-alpha
Development

Successfully merging this pull request may close these issues.
1 participant
@MicahGale