Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.8 support, and add python 3.13 and numpy 2.0 support #548

Merged
merged 13 commits into from
Oct 8, 2024

Conversation

MicahGale
Copy link
Collaborator

@MicahGale MicahGale commented Sep 15, 2024

Description

Please include a summary of the change and which issue is fixed if applicable. Please also include relevant motivation and context.

Fixes #201, fixes #457

Checklist

  • I have performed a self-review of my own code
  • Remove fail-fast flag.

@MicahGale MicahGale self-assigned this Sep 15, 2024
@MicahGale MicahGale added CI/CD code improvement A feature request that will improve the software and its maintainability, but be invisible to users. labels Sep 15, 2024
@MicahGale MicahGale marked this pull request as ready for review September 30, 2024 12:48
@MicahGale
Copy link
Collaborator Author

Want to review this now @tjlaboss, so if everything passes tomorrow we can merge on Python day?

@MicahGale
Copy link
Collaborator Author

It looks like pytest-profile is incompatible with 3.13. I'm thinking of just uninstalling it for now as a work around

@tjlaboss
Copy link
Collaborator

tjlaboss commented Oct 3, 2024

Yeah, we can remove it from CI and just profile <=3.12 locally

@MicahGale
Copy link
Collaborator Author

We can still profile. Just do the profiling on <= 3.12 in CI. We don't need profiling to run the test suite in 3.13

Copy link
Collaborator

@tjlaboss tjlaboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending Python 3.13 CI

@MicahGale MicahGale merged commit a7f8112 into develop Oct 8, 2024
20 checks passed
@MicahGale MicahGale deleted the kill_38 branch October 8, 2024 15:17
@MicahGale MicahGale mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD code improvement A feature request that will improve the software and its maintainability, but be invisible to users.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decide how to test against Numpy 1 and 2 End of Life for python 3.8 support
2 participants