Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidating Joule Heating Objects & Generalizing EM Module Coupling by Utilizing the Material Object System #30191

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

csdechant
Copy link
Contributor

Reason

As the electromagnetic module matures, different formulations of the same physics phenomena (e.g. electrostatic vs electromagnetic) are introduced into MOOSE and housed in different modules. One such example is the electrostatic and electromagnetic versions of Joule heating, which are housed in the heat transfer and electromagnetic modules, respectively. This PR consolidates these versions of the Joule heating objects into the heat transfer module by utilizing the material object system.

This PR would closes #30000

Design

This PR involves the following changes:

  • Adds a new material object into the heat transfer module, ElectromagneticHeatingMaterial, which supplies the electric field and the residuals for electromagnetic/electrostatic heating based objects. ElectromagneticHeatingMaterial calculates the correct formulation of the Joule heating for either electrostatic or electromagnetic cases in either the time or frequency domain.
  • Consolidates the electromagnetic module objects EMJouleHeatingSource and EMJouleHeatingHeatGeneratedAux into the heat transfer objects ADJouleHeatingSource and JouleHeatingHeatGeneratedAux.
  • Updated tests and documentation for the new and edited objects.
  • Sets a 6 months deprecation (10/01/2025) timeframe for the following objects and features:
    • EMJouleHeatingSource
    • EMJouleHeatingHeatGeneratedAux
    • Directly coupling the electrostatic potential into ADJouleHeatingSource and JouleHeatingHeatGeneratedAux (after deprecation, electrostatic potential will only be coupled through the ElectromagneticHeatingMaterial object)
    • JouleHeatingSource (this is because JouleHeatingSource is currently not planned to be compatible with ElectromagneticHeatingMaterial, thus limiting JouleHeatingSource to only electrostatic cases)

Impact

The impact of combining these different formulations of electromagnetic based physics would allow for a more streamline implantation of the electromagnetic module and EM coupled objects from a user standpoint.

@csdechant
Copy link
Contributor Author

csdechant commented Mar 25, 2025

@sapitts This is the PR I talked to you about offline. Please let me know if you have any questions or concerns.

@moosebuild
Copy link
Contributor

Job Documentation, step Docs: sync website on 0dafe84 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Coverage, step Generate coverage on 0dafe84 wanted to post the following:

Framework coverage

Coverage did not change

Modules coverage

Electromagnetics

4e9f7e #30191 0dafe8
Total Total +/- New
Rate 94.84% 94.86% +0.02% 100.00%
Hits 625 627 +2 2
Misses 34 34 - 0

Diff coverage report

Full coverage report

Heat transfer

4e9f7e #30191 0dafe8
Total Total +/- New
Rate 88.64% 88.91% +0.26% 91.57%
Hits 4457 4537 +80 76
Misses 571 566 -5 7

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

@cticenhour cticenhour self-assigned this Mar 26, 2025
@cticenhour cticenhour requested a review from sapitts March 26, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generalizing and Combining Electrostatic & Electromagnetic Objects Coupled with the EM Module
3 participants