Advance multiroot workspace support #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This forces '--showfile' mode to make linter stable whether the option passed directly by the arg or implicitly by .config file
By design linter is run from the directory where the repo containing commit is located. And in case when there is no '--show-types' option passed the resulting log violates expected format and parseCheckpatchLog() doesn't see what it should. Forcing the option fixes the problem.
tolezk
changed the title
a) This adds an ability to have a workspace-folder-specific checkpatch config. This useful in case when you have projects with different requirements in your multiroot workspace. b) This adds a checkpatch-specific output channel (output pane of vscode) c) This adds 'Clean Current Diagnostic' command to clean up problems pane manually
tolezk
changed the title
|
@tolezk I might need a few extra days to go over this change and to test it.
? |
|
Probably it may look like a mess (sorry for that, but I decided it's better to go as is than not to go) but this change does the following:
|
|
@idanpa please provide any feedback and I'll try to find some bandwidth to rearrange this in a way to make it easier to validate all the changes for you. Or let me know if you gonna reject this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, this commit introduces some changes. The most noticeable change is multiroot workspace support in a quite flexible way.