Subhampal9 current mirror fix #355
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. drc and lvs reports are also attached 2. sample picture of gds is attached 3. README file and annotations in fvf.py are added
added FVF Pcell files, Analog Vibes, Chipathon 2024
Previously a ptap and pwell was layed out irrespective of the device type. Added the code to add specific tap and well layers for each device type
|
|
||
| return netlist | ||
|
|
||
| def sky130_add_fvf_labels(fvf_in: Component) -> Component: |
There was a problem hiding this comment.
Can this function be made pdk agnostic?
There was a problem hiding this comment.
This function is only used for LVS check
There was a problem hiding this comment.
That is fine. Is it specific to the sky130 pdk? If so, can it be made generic using the MappedPDK class?
There was a problem hiding this comment.
It uses layers which are not mapped in Mappedpdk(as far as I know).
There was a problem hiding this comment.
Oh, in that case it is fine.
…F directory Now it only contains the change in current_mirror block
msaligane
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://open-source-silicon.slack.com/archives/C072ZFE19FH/p1732758626658539?thread_ts=1732636138.678739&cid=C072ZFE19FH
Previously ptap and pwell was getting layed out irrespective of the device type. Codes were added to add tap and well layers depending on the device type