C route and other fixes #358
Conversation
Subhampal9
commented
Dec 19, 2024
Subhampal9
commented
- added code to add more vias at intermediate nodes of c_route
- minor fix in four transistor interdigitized block
1. drc and lvs reports are also attached 2. sample picture of gds is attached 3. README file and annotations in fvf.py are added
added FVF Pcell files, Analog Vibes, Chipathon 2024
There was a problem hiding this comment.
Can you remove these files and only keep the files relevant to the fix?
There was a problem hiding this comment.
Can you highlight which lines were changed? Or revert the styling changes so that the diff only shows the relevant changes.
There was a problem hiding this comment.
I have added some comments where the changes are
added comments to show the changes
| raise ValueError("Ports must be parralel and have same orientation") | ||
| width1 = width1 if width1 else edge1.width | ||
| width2 = width2 if width2 else edge1.width | ||
| cwidth = cwidth if cwidth else max(width1,width2) |
There was a problem hiding this comment.
What is cwidth here? It is an argument but there is no description for it in the docstring. Can you add a line for it?
There was a problem hiding this comment.
it is the width of the intermediate connection route
| if round(edge1.orientation) == 90 or round(edge1.orientation) == 270: | ||
| viastack1 = via_array(pdk, e1glayer, cglayer, size=(width1,cwidth), fullbottom=fullbottom, no_exception=True) | ||
|
|
||
| viastack2_dims = evaluate_bbox(viastack2,True) |
There was a problem hiding this comment.
The code repeats here. Can you use loops or some other method to reduce the duplication?
There was a problem hiding this comment.
via_array is taking different sizes in each case, I am not sure how I can loop it.
There was a problem hiding this comment.
You can create a list and iterate over it. It is not required though.
There was a problem hiding this comment.
So, should I leave it as it is?
| viastack2 = via_stack(pdk,e2glayer,cglayer,fullbottom=fullbottom,assume_bottom_via=True,fulltop=True) | ||
|
|
||
| viastack1_dims = evaluate_bbox(viastack1,True) | ||
| #condition checking for multiple vias at first intermediate node |
There was a problem hiding this comment.
Can you also describe the condition here? eg: "Creates a via array if ..."
added comments and updated docstring
There was a problem hiding this comment.
@Subhampal9 Great work! It would be good to start documenting some of the changes. Can you add some simple readmes for c_route for instance.
Will do that soon. |
