Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[migrate] upgrade to ESLint 9, Node.js 20 & other latest Upstream packages/actions #16
[migrate] upgrade to ESLint 9, Node.js 20 & other latest Upstream packages/actions #16
Changes from 1 commit
8fbea75
27db057
cd6c828
14be837
8fb6fa5
ec93488
d74b359
9d9cdbb
61ec37f
dfe4e7f
78cf39b
d552b30
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
先格式化再检查代码规范会比较好
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
格式不对会影响 eslint 规则通过?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有少数规则会,因为代码越格式规范出问题的概率越小。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
官方文档推荐写的,一个是代码质量规则,一个是格式化规则,它们的交集也用插件 disable 了,很难想象格式会影响代码质量检查
https://github.com/lint-staged/lint-staged#task-concurrency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
按照步骤,只要
eslint --fix
出问题都会再过一遍,用 prettier 收尾是正常流程?