Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/update #32

Merged
merged 20 commits into from
Nov 22, 2024
Merged

Feat/update #32

merged 20 commits into from
Nov 22, 2024

Conversation

driemworks
Copy link
Contributor

@driemworks driemworks commented Oct 24, 2024 •
edited
Loading

@driemworks driemworks self-assigned this Oct 24, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
murmur ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 8:15pm

@driemworks driemworks marked this pull request as draft October 24, 2024 01:33
@driemworks driemworks marked this pull request as ready for review October 29, 2024 16:17
juangirini
juangirini reviewed Oct 30, 2024
View reviewed changes
core/src/murmur.rs Outdated Show resolved Hide resolved
@juangirini
Copy link
Contributor

@driemworks this PR closes #13 too, right?

@driemworks
Copy link
Contributor Author

@driemworks this PR closes #13 too, right?

yeah it does, good catch. The change I made uses a transcript hasher (shake128 XoF under the hood) in place of an HKDF.

juangirini
juangirini reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@juangirini juangirini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should keep this as a draft while it's WIP

core/Cargo.toml Outdated Show resolved Hide resolved
lib/src/bin/murmur/main.rs Outdated Show resolved Hide resolved
lib/src/bin/murmur/main.rs Outdated Show resolved Hide resolved
@driemworks driemworks marked this pull request as draft November 18, 2024 02:15
@driemworks
Copy link
Contributor Author

we should keep this as a draft while it's WIP

agreed, I'll keep it as a draft until the timelock lib PR is merged

@driemworks driemworks marked this pull request as ready for review November 21, 2024 16:12
juangirini
juangirini approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@juangirini juangirini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

core/Cargo.toml Outdated Show resolved Hide resolved
core/README.md Outdated Show resolved Hide resolved
core/README.md Outdated Show resolved Hide resolved
core/README.md Outdated Show resolved Hide resolved
@driemworks driemworks merged commit ab46271 into main Nov 22, 2024
1 of 3 checks passed
@driemworks driemworks deleted the feat/update branch November 22, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juangirini juangirini juangirini approved these changes

@colemanirby colemanirby Awaiting requested review from colemanirby

@carloskiron carloskiron Awaiting requested review from carloskiron

Assignees

@driemworks driemworks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@driemworks @juangirini