Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/350 Fix ConfigParser Error for New Teams Workflow URL (#350) #356

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

MarcelMWS
Copy link

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions
  • Remember to set idealista:develop as base branch;

Description of the Change

  • Issue Addressed: Fixes configparser error related to new Teams URL/workflow (see comment: Issue #350):

    • configparser.InterpolationSyntaxError: '%' must be followed by '%' or '(', found: '%2Ftriggers%2Fmanual%2Frun&sv=1.0&s'
  • Enhancement: You can now insert Teams workflow URLs without needing to escape the % character.

Benefits

  • Dependency Upgrade: Updated dependencies to address all vulnerabilities and CVEs in the image.

Possible Drawbacks

Applicable Issues

I intended to check out the develop branch but mistakenly checked out version 5.0.0 instead. I ended up reverting two commits, effectively returning to a state similar to the develop branch. I’ll be sure to double-check my branch next time.

Tests

  • Running Tests...
  • Test 1: OK
  • Test 2: OK
  • Test 3: OK
  • Destroying Containers...
  • TESTS FINISHED SUCCESSFULLY

Copy link

@angelosnm angelosnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebagarayco
Copy link

Hitting this issue. Is this going to be merged soon?

@Cute-Monster
Copy link

Cute-Monster commented Dec 9, 2024

Hitting this issue. Is this going to be merged soon?

Hi @sebagarayco,
As workaround you can replace %2F with actual human-readable value / 😺
This helped me to avoid this issue while migrating to new MS Teams workflow flow

@sebagarayco
Copy link

Hitting this issue. Is this going to be merged soon?

Hi @sebagarayco, As workaround you can replace %2F with actual human-readable value / 😺 This helped me to avoid this issue while migrating to new MS Teams workflow flow

You rock, that did it. Appreciate it!

@angelosnm
Copy link

Guys...it is just one click away...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants