Skip to content

Commit

Permalink
fix find_min resource leak bug
Browse files Browse the repository at this point in the history
  • Loading branch information
ideawu authored Sep 17, 2020
1 parent b9bdd6b commit c0c3bca
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/ssdb/binlog.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,7 @@ int BinlogQueue::find_min(Binlog *log) const{
}
}
}
delete it;
return ret;
}

Expand Down

1 comment on commit c0c3bca

@ghen2
Copy link
Contributor

@ghen2 ghen2 commented on c0c3bca Sep 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our ssdb data directory shrunk dramatically since this change (from 4-5 GB to less than one GB), mostly short-lived data so binlog is larger than the actual data.

Please sign in to comment.