Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table cell render bug #30

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Table cell render bug #30

merged 2 commits into from
Jan 15, 2025

Conversation

GAOChengzhan
Copy link
Contributor

@GAOChengzhan GAOChengzhan commented Nov 3, 2024

This Ticket is a bug occurs when the network is large and does not have a layout:

image

1. OK -> Apply random layout -> Sometimes the network view is blank

2. Cancel -> No network view -> Table cells do not render correctly.

1. The network view becomes blank

This bug happens randomly and is related to the package deck.gl. Since the layout is randomized and the network size is large, some pixel project matrix becomes non-invertible during rendering. As a result, the network view fails to render and appears blank.

image

In summary, when no pixel project matrices are non-invertible during calculations in the deck.gl, the network view can be rendered correctly, otherwise, it would become blank. I also tried to upgrade the package version from 8.x to 9.0 but the bug still occurs from time to time.

Matrix is NOT invertible Matrix is invertible
image image

2. Cell Not Rendered Correctly

This issue can be resolved by checking for empty data before rendering(See src/components/DataPanel/EntryTable/VirtualizedTable2.tsx). Once addressed, selecting the "Cancel" option will bring users to the following screen:

image

@GAOChengzhan
Copy link
Contributor Author

GAOChengzhan commented Jan 14, 2025

Changes Made:

  • src/components/DataPanel/EntryTable/VirtualizedTable2.tsx:
    Added a checker for the 'header' list, which mainly resolved the rendering bug that crashes the server
  • src/components/MainSplitPane/InitializationPanel.tsx:
    Added keycloak login function and discarded the BasicAuth stuff
  • src/components/NdexLogin/NdexSignInButton/NdexSignInButton.tsx:
    Added redirect URL for keycloak logout and discarded the BasicAuth stuff
  • All other changes made are deletion of useless code lines.

@jingjingbic jingjingbic merged commit 2e6ce81 into develop Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants