Merge pull request #121 from iden3/fix/gha-release-ios

Fix the release of binded Go to iOS in GHA
iden3 · May 29, 2020 · 236d5c7 · 236d5c7
2 parents 0f8e41b + 8ec7138
commit 236d5c7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/gomobile.yml b/.github/workflows/gomobile.yml
@@ -8,8 +8,10 @@ on:
 
 jobs:
   bind-go-android:
-    name: Gomobile
+    name: Release Go binded to Android
     runs-on: ubuntu-latest
+    outputs:
+      release_upload_url: ${{ steps.create_release.outputs.upload_url }}
     steps:
 
     - uses: actions/checkout@v2
@@ -108,7 +110,8 @@ jobs:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
   bind-go-ios:
-    name: Test Go
+    name: Release Go binded to iOS
+    needs: bind-go-android 
     runs-on: macos-latest
     steps:
 
@@ -135,7 +138,7 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
-          upload_url: ${{ steps.create_release.outputs.upload_url }}
+          upload_url: ${{ needs.bind-go-android.outputs.release_upload_url }}
           asset_path: /tmp/build/Iden3mobile.framework
           asset_name: Iden3mobile.framework
           asset_content_type: application/zip
diff --git a/go/iden3mobile/httpclient.go b/go/iden3mobile/httpclient.go
@@ -51,6 +51,7 @@ func NewHttpClient(urlBase string) *HttpClient {
 	return &HttpClient{HttpClient: *httpclient.NewHttpClient(urlBase)}
 }
 
+// DoRequest performs an HTTP request
 func (p *HttpClient) DoRequest(s *sling.Sling, res interface{}) error {
 	err := p.HttpClient.DoRequest(s, res)
 	switch e := err.(type) {