Few small changes #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovesh
commented
Aug 23, 2022
lovesh
commented
- Some formatting and typo fixes in r1cs_bin_format.md
- Some code comments in r1cs parser
- Fixing function name in Readme
- Some formatting and typo fixes in r1cs_bin_format.md - Some code comments in r1cs parser - Fixing function name in Readme
mratsim
reviewed
Dec 28, 2023
| @@ -506,9 +506,9 @@ Variable size for field elements allows to shrink the size of the file and allow | |||
|
|
|||
| Version allows to update the format. | |||
|
|
|||
| Have a very good comprasion ratio for sparse r1cs as it's the normal case. | |||
| Have a very good comparison ratio for sparse r1cs as it's the normal case. | |||
There was a problem hiding this comment.
Suggested change
| Have a very good comparison ratio for sparse r1cs as it's the normal case. | |
| Have a very good compression ratio for sparse r1cs as it's the normal case. |
mratsim
reviewed
Dec 28, 2023
| @@ -146,7 +146,7 @@ Section Type: 0x01 | |||
| ┃ 4 │ 20 00 00 00 ┃ Field Size in bytes (fs) | |||
| ┗━━━━┻━━━━━━━━━━━━━━━━━┛ | |||
| ┏━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓ | |||
| ┃ fs │ 010000f0 93f5e143 9170b979 48e83328 5d588181 b64550b8 29a031e1 724e6430 ┃ Prime size | |||
| ┃ fs │ 010000f0 93f5e143 9170b979 48e83328 5d588181 b64550b8 29a031e1 724e6430 ┃ Prime | |||
| ┗━━━━┻━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛ | |||
| ┏━━━━┳━━━━━━━━━━━━━━━━━┓ | |||
| ┃ 32 │ 01 00 00 00 ┃ nWires | |||
There was a problem hiding this comment.
Another issue is that the field size field uses bytes as unit, while nWires and the rest use bits in the diagram.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.