-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from js-sha3 and blake to audited noble-hashes #547
base: master
Are you sure you want to change the base?
Conversation
} | ||
|
||
export function fromPartialHash(partial) { | ||
// NOTE: this is unsafe and uses internal API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @paulmillr!
Thank you for your contribution! I imagine it was a lot of work!
Can you please elaborate on this comment? Why is it unsafe?
Just because of the usage of internal API or there are other considerations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s because it uses internal api.
stuff like this is never exposed in libraries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need "partial hashes"?
@Kolezhniuk can you please test this build on our multiplatform tests setup? |
noble cryptography (https://github.com/paulmillr/noble-hashes) is high-security, easily auditable set of contained cryptographic libraries and tools. It would be great to use it instead of some unknown library. Benefits:
All PRs:
Originally proposed 15 months ago in #416