refactor:integration tests #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeping them split showed several issues: - Concurrent access to the cache is not working (fixed by using one cache per test suit) - Each suit would rebuild all its the dependencies which means that the cost on disk would balloon as well as the time spent to rebuild the same artifacts - Each suit being independent, in the package sense, means sharing package level variables such as settings was not possible.
This follows the same scheme as python-installers.
It is not tested in the pip buildpack and it's currently failing during cpython installation. The symlink creation from python3 to python fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR puts the integration tests of all the installers under one folder and thus one package.
Having them separated had the following issues:
The last point might be possible to some extent using the go:linkname directive but that's not even sure.