Support icmp traffic #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Str-Gen
approved these changes
Jul 10, 2024
mielverkerken
commented
Jul 11, 2024
| let icmp_type = icmp_packet.get_icmp_type(); | ||
| let icmp_code = icmp_packet.get_icmp_code(); | ||
| // let icmp_type = icmp_packet.get_icmp_type(); | ||
| // let icmp_code = icmp_packet.get_icmp_code(); | ||
| source_port = 0; // ICMPv6 does not have ports | ||
| destination_port = 0; | ||
| data_length = icmp_packet.payload().len() as u16; |
There was a problem hiding this comment.
Can we remove the hard coded header_length of 8 for udp and icmp in the Rustiflow code and extract the header length from both the realtime and pcap?
There was a problem hiding this comment.
For the realtime, this is possible but it is pointer work to get the header length.
Str-Gen
approved these changes
Jul 11, 2024
Str-Gen
approved these changes
Jul 11, 2024
Str-Gen
approved these changes
Jul 17, 2024
Str-Gen
approved these changes
Jul 17, 2024
matissecallewaert
approved these changes
Jul 22, 2024
| let icmp_type = icmp_packet.get_icmp_type(); | ||
| let icmp_code = icmp_packet.get_icmp_code(); | ||
| // let icmp_type = icmp_packet.get_icmp_type(); | ||
| // let icmp_code = icmp_packet.get_icmp_code(); | ||
| source_port = 0; // ICMPv6 does not have ports | ||
| destination_port = 0; | ||
| data_length = icmp_packet.payload().len() as u16; |
There was a problem hiding this comment.
For the realtime, this is possible but it is pointer work to get the header length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for icmp traffic. Might be interesting to finish icmp flows on reply after requst.