Nando's PR review comments done

idos-network · Dec 5, 2024 · 0d8ec81 · 0d8ec81
1 parent 90ed536
commit 0d8ec81
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 8 deletions.
diff --git a/...apps/src/components/grants-pagination.tsx → ...d-for-dapps/src/components/pagination.tsx b/...apps/src/components/grants-pagination.tsx → ...d-for-dapps/src/components/pagination.tsx
@@ -1,7 +1,12 @@
-import { HStack, PaginationNextTrigger, PaginationPrevTrigger } from "@chakra-ui/react";
-import { PaginationItems, PaginationRoot } from "./ui/pagination";
+import { HStack } from "@chakra-ui/react";
+import {
+  PaginationItems,
+  PaginationNextTrigger,
+  PaginationPrevTrigger,
+  PaginationRoot,
+} from "@idos-network/ui-kit";
 
-export default function GrantsPagination({
+export function Pagination({
   count,
   pageSize,
   page,

diff --git a/...board-for-dapps/src/mokc/access-grants.ts → ...board-for-dapps/src/mock/access-grants.ts b/...board-for-dapps/src/mokc/access-grants.ts → ...board-for-dapps/src/mock/access-grants.ts
diff --git a/apps/dashboard-for-dapps/src/routes/index.tsx b/apps/dashboard-for-dapps/src/routes/index.tsx
@@ -46,9 +46,9 @@ import { matchSorter } from "match-sorter";
 import { useMemo, useRef, useState } from "react";
 import nacl from "tweetnacl";
 
-import GrantsPagination from "@/components/grants-pagination";
+import { Pagination } from "@/components/pagination";
 import { useIdOS } from "@/idOS.provider";
-import { mockFetchAccessGrants } from "@/mokc/access-grants";
+import { mockFetchAccessGrants } from "@/mock/access-grants";
 
 export const Route = createFileRoute("/")({
   component: Index,
@@ -69,7 +69,7 @@ function transformBase85Image(src: string) {
 
 const useFetchGrants = (page: number) => {
   return useQuery({
-    queryKey: ["grants", page],
+    queryKey: ["grants", { page }],
     queryFn: () => mockFetchAccessGrants(page, 5),
     select: (data) => ({
       ...data,
@@ -469,7 +469,7 @@ function SearchResults({
           </Button>
         </Stack>
       ))}
-      <GrantsPagination count={results.totalRecords} pageSize={5} setPage={setPage} page={page} />
+      <Pagination count={results.totalRecords} pageSize={5} setPage={setPage} page={page} />
       <SecretKeyPrompt
         {...{ open: openSecretKeyPrompt, toggle: toggleSecretKeyPrompt, onSubmit: onKeySubmit }}
       />

diff --git a/packages/ui/package.json b/packages/ui/package.json
@@ -16,7 +16,9 @@
     "./password-input": "./src/components/password-input.tsx",
     "./provider": "./src/components/provider.tsx",
     "./refresh-button": "./src/components/refresh-button.tsx",
-    "./search-field": "./src/components/search-field.tsx"
+    "./search-field": "./src/components/search-field.tsx",
+    "./pagination": "./src/components/pagination.tsx",
+    "./link-button": "./src/components/link-button.tsx"
   },
   "scripts": {
     "lint": "biome check --apply ./src",

diff --git a/packages/ui/src/components/index.ts b/packages/ui/src/components/index.ts
@@ -10,3 +10,5 @@ export * from "./password-input";
 export * from "./provider";
 export * from "./refresh-button";
 export * from "./search-field";
+export * from "./pagination";
+export * from "./link-button";
diff --git a/...r-dapps/src/components/ui/link-button.tsx → packages/ui/src/components/link-button.tsx b/...r-dapps/src/components/ui/link-button.tsx → packages/ui/src/components/link-button.tsx
diff --git a/...or-dapps/src/components/ui/pagination.tsx → packages/ui/src/components/pagination.tsx b/...or-dapps/src/components/ui/pagination.tsx → packages/ui/src/components/pagination.tsx