Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent multiple iframes creation #365

Merged
merged 8 commits into from
Dec 2, 2024
Merged

fix: prevent multiple iframes creation #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7d10543
fix the condition that prevents multiple iframes creation
Mohammed-Mamoun98 Nov 25, 2024
b5246f8
update related README
Mohammed-Mamoun98 Nov 25, 2024
63b2a39
replacing throwing error on duplicated initializtion to returning ini…
Mohammed-Mamoun98 Nov 26, 2024
2b442f7
remove the note from readme file
Mohammed-Mamoun98 Nov 27, 2024
3d72895
remove the need to memoize idos instance. at #loadEnclave a check for…
Mohammed-Mamoun98 Nov 28, 2024
913bd12
Merge branch 'main' of github.com:idos-network/idos-sdk-js into feat/…
Mohammed-Mamoun98 Nov 28, 2024
37d1b38
remove unnecessary string literals
Mohammed-Mamoun98 Nov 28, 2024
8639499
removing extra iframe listener - replace with direct resolve
Mohammed-Mamoun98 Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/idos-sdk-js/src/lib/enclave-providers/iframe-enclave.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,12 @@ export class IframeEnclave implements EnclaveProvider {
}

async #loadEnclave() {
const hasIframe = document.getElementById(this.iframe.id);
if (hasIframe) {
console.warn("An Iframe already exists in the container");
return Promise.resolve();
}

// https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Permissions-Policy#directives
const permissionsPolicies = ["publickey-credentials-get", "storage-access"];

Expand Down
2 changes: 1 addition & 1 deletion packages/idos-sdk-js/src/lib/idos.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ interface InitParams {

export class idOS {
static initializing = false;

static near = Grants.near;
static evm = Grants.evm;
static kwil = KwilWrapper.defaults;
Expand Down Expand Up @@ -109,6 +108,7 @@ export class idOS {

async reset({ enclave = false } = {}): Promise<void> {
this.store.reset();
idOS.initializing = false;
if (enclave) await this.enclave.reset();
}

Expand Down
Loading