Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client-sdk): allow to pass synchronous flag for kwil executions #367

Merged
merged 5 commits into from
Nov 29, 2024
Merged

feat(client-sdk): allow to pass synchronous flag for kwil executions #367

merged 5 commits into from
Nov 29, 2024

Conversation

ditoglez
Copy link
Collaborator

No description provided.

@vercel Vercel
Copy link

vercel bot commented Nov 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-for-dapps ❌ Failed (Inspect) Nov 29, 2024 5:36pm
idos-data-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 5:36pm
idos-enclave ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 5:36pm
idos-example-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 5:36pm

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 27, 2024 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/idos-network/idos-sdk-js/@idos-network/idos-sdk@367

npm i https://pkg.pr.new/idos-network/idos-sdk-js/@idos-network/issuer-sdk-js@367

commit: 00c6cc4

@ditoglez ditoglez requested a review from pkoch November 28, 2024 08:36
pkoch
pkoch reviewed Nov 28, 2024
View reviewed changes
Copy link
Member

@pkoch pkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's instead force it to be true on kwil wrapper. No need for more variables.

@ditoglez ditoglez force-pushed the feat/synchronous-kwil-mutations branch from d889eb1 to d6b1404 Compare November 29, 2024 08:58
pkoch
pkoch approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@pkoch pkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't try it out, but the change looks good. 👌

@ditoglez ditoglez requested a review from juliosantos November 29, 2024 11:27
@ditoglez ditoglez merged commit 507125c into main Nov 29, 2024
10 checks passed
@ditoglez ditoglez deleted the feat/synchronous-kwil-mutations branch November 29, 2024 17:35
@pkoch pkoch removed the do not merge label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkoch pkoch pkoch approved these changes

@juliosantos juliosantos Awaiting requested review from juliosantos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ditoglez @pkoch