Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove credential v1 fallback #372

Merged
merged 5 commits into from
Dec 3, 2024
Merged

refactor: remove credential v1 fallback #372

merged 5 commits into from
Dec 3, 2024

Conversation

Mohammed-Mamoun98
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Dec 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-for-dapps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 1:48pm
idos-data-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 1:48pm
idos-enclave ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 1:48pm
idos-example-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 1:48pm

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 3, 2024 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/idos-network/idos-sdk-js/@idos-network/idos-sdk@372

npm i https://pkg.pr.new/idos-network/idos-sdk-js/@idos-network/issuer-sdk-js@372

commit: 77c54ca

ditoglez
ditoglez requested changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@ditoglez ditoglez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that its better to start being future proof already. Instead of targeting specific fields, lets start spreading whatever we have in the public_notes. The dashboard should be already able of rendering it.

@ditoglez ditoglez changed the title Feat/remove cred v1 fallbacks refactor: remove credential v1 fallback Dec 3, 2024
@ditoglez ditoglez self-requested a review December 3, 2024 13:46
@Mohammed-Mamoun98 Mohammed-Mamoun98 merged commit c6f6603 into main Dec 3, 2024
10 checks passed
@Mohammed-Mamoun98 Mohammed-Mamoun98 deleted the feat/remove-cred-v1-fallbacks branch December 3, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ditoglez ditoglez ditoglez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mohammed-Mamoun98 @ditoglez