Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add codecs library and refactor client and issuer sdk's to use it #388

Merged
merged 2 commits into from
Dec 16, 2024
Merged

chore: add codecs library and refactor client and issuer sdk's to use it #388

merged 2 commits into from
Dec 16, 2024

Conversation

ditoglez
Copy link
Collaborator

@ditoglez ditoglez commented Dec 12, 2024 •
edited
Loading

No description provided.

@vercel Vercel
Copy link

vercel bot commented Dec 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-for-dapps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2024 3:50pm
idos-data-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2024 3:50pm
idos-enclave ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2024 3:50pm
idos-example-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2024 3:50pm

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 12, 2024 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/idos-network/idos-sdk-js/@idos-network/idos-sdk-server-dapp@388

npm i https://pkg.pr.new/idos-network/idos-sdk-js/@idos-network/idos-sdk@388

npm i https://pkg.pr.new/idos-network/idos-sdk-js/@idos-network/issuer-sdk-js@388

commit: f0e38f3

@vercel vercel bot temporarily deployed to Preview – idos-example-dapp December 12, 2024 18:57 Inactive
@ditoglez ditoglez changed the title chore: codecs library chore: codecs library and refactor client sdk to use it Dec 12, 2024
@ditoglez ditoglez changed the title chore: codecs library and refactor client sdk to use it chore: add codecs library and refactor client sdk to use it Dec 12, 2024
@ditoglez ditoglez changed the title chore: add codecs library and refactor client sdk to use it chore: add codecs library and refactor client and issuer sdk's to use it Dec 12, 2024
@vercel vercel bot temporarily deployed to Preview – idos-example-dapp December 12, 2024 19:04 Inactive
@vercel vercel bot temporarily deployed to Preview – idos-example-dapp December 12, 2024 19:11 Inactive
@vercel vercel bot temporarily deployed to Preview – idos-example-dapp December 12, 2024 19:15 Inactive
@ditoglez ditoglez requested a review from pkoch December 12, 2024 19:22
pkoch
pkoch reviewed Dec 13, 2024
View reviewed changes
pkoch
pkoch reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@pkoch pkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not opposed at all. Let's just make sure we use the formulation that most facilitates tree shaking.

@ditoglez ditoglez requested a review from pkoch December 13, 2024 10:44
@vercel vercel bot temporarily deployed to Preview – idos-example-dapp December 13, 2024 10:48 Inactive
pkoch
pkoch approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@pkoch pkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Careful with the conflicts. Other than that, 🚀.

@ditoglez ditoglez force-pushed the chore/add-codecs-library branch from f138f45 to ac4a2b0 Compare December 14, 2024 15:15
@vercel vercel bot temporarily deployed to Preview – idos-example-dapp December 14, 2024 15:16 Inactive
@ditoglez ditoglez force-pushed the chore/add-codecs-library branch from ac4a2b0 to 6a6807e Compare December 14, 2024 15:28
@vercel vercel bot temporarily deployed to Preview – idos-example-dapp December 14, 2024 15:29 Inactive
@ditoglez ditoglez force-pushed the chore/add-codecs-library branch from 6a6807e to b48da45 Compare December 14, 2024 15:31
@vercel vercel bot temporarily deployed to Preview – idos-example-dapp December 14, 2024 15:33 Inactive
@vercel vercel bot temporarily deployed to Preview – idos-example-dapp December 14, 2024 15:50 Inactive
@ditoglez ditoglez merged commit 33fba6c into main Dec 16, 2024
10 checks passed
@ditoglez ditoglez deleted the chore/add-codecs-library branch December 16, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkoch pkoch pkoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ditoglez @pkoch