Rel #33
Merged
Rel #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 25, 2017 16:16
|
Ready for review. |
yurrriq
requested changes
Aug 1, 2017
src/Rel.lidr
Outdated
|
|
||
| \ \todo[inline]{Again, "earlier" = \idr{IndProp}} | ||
|
|
||
| Show that the idr{Total_relation} defined in earlier is not a partial function. |
src/Rel.lidr
Outdated
|
|
||
| ==== Exercise: 2 stars, optional | ||
|
|
||
| Show that the idr{Empty_relation} that we defined earlier is a partial function. |
| > | ||
| > syntax [p] "<->" [q] = iff {p} {q} | ||
|
|
||
| > next_nat_closure_is_le : (n <=' m) <-> (Clos_refl_trans Next_nat n m) |
There was a problem hiding this comment.
Note for later: minted handles this definition poorly. See also #30.
There was a problem hiding this comment.
So what should we do here? Add a todo?
|
Other than those little comments this looks good to me. |
|
Feel free to merge this one yourself after those trivial changes. |
|
Sure, though linking the relevant issue in my previous comment might be enough. This is a toolchain issue rather than a code one. |
|
Let's merge |
yurrriq
approved these changes
Aug 3, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.