To/#181 reduced grid model

[t-ober]

Resolves #181

[t-ober]

!test

[ckittl]

The core of the changes you propse look good. However, I'd like to ask you to remove the more "hacky" parts and put a bit more emphasize on the structure.

[ckittl]

You may consider adding those parameters to the method signature and assign default values. Once again, you would be more flexible in the way you can apply the method.

[t-ober]

I only create these system participants so I can overwrite their behavior with primary data so the parameters don't matter and I do not think that this comes in handy anywhere else.

[ckittl]

Okay, in that scenario it actually works. However, the model after that is then "implicitly" bound to only be used in conjunction with a primary data source.

I'm a bit worrying about other people coming accross the repository in some months or years and using the created models in a fashion, that is physically / simulation-wise not sensible. Maybay you can add a warning to the README.md then?

[t-ober]

I did add words of warnings to the method descriptions. Since the models don't ship with the code you shouldn't be able to use the models incorrectly and I think with the added comment it should be sufficiently clear.

[t-ober]

I did add words of warnings to the method descriptions. Since the models don't ship with the code you shouldn't be able to use the models incorrectly and I think with the added comment it should be sufficiently clear.

[codecov]

Codecov Report

Merging #185 (5b2fd34) into main (57c4f03) will decrease coverage by 2.53%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
- Coverage   86.45%   83.91%   -2.54%     
==========================================
  Files          40       41       +1     
  Lines         967     1032      +65     
  Branches        2        2              
==========================================
+ Hits          836      866      +30     
- Misses        131      166      +35     

Impacted Files	Coverage Δ
...edu/ie3/powerFactory2psdm/main/RunConversion.scala	0.00% <0.00%> (ø)
...la/edu/ie3/powerFactory2psdm/io/PfGridParser.scala
...e3/powerFactory2psdm/reduce/GridModelReducer.scala	50.00% <0.00%> (ø)
...n/scala/edu/ie3/powerFactory2psdm/io/IoUtils.scala	37.83% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57c4f03...5b2fd34. Read the comment docs.

[sonarqubegithubprchecks]

Analysis Details

1 Issue

• 0 Bugs
• 0 Vulnerabilities
• 1 Code Smell

Coverage and Duplications

• 41.67% Coverage (83.90% Estimated after merge)
• 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:powerFactory2psdm

View in SonarQube