Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pv power fix #210

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Pv power fix #210

wants to merge 11 commits into from

Conversation

t-ober
Copy link
Contributor

@t-ober t-ober commented Mar 22, 2022

Resolves #209 - messed up branch naming

@t-ober t-ober added the bug Something isn't working label Mar 22, 2022
@sonarqubegithubprchecks

This comment has been minimized.

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #210 (140d553) into main (1aa66a6) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 140d553 differs from pull request most recent head 37b8e93. Consider uploading reports for the commit 37b8e93 to get more accurate results

@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
+ Coverage   86.45%   86.49%   +0.04%     
==========================================
  Files          40       40              
  Lines         967      970       +3     
  Branches        2        2              
==========================================
+ Hits          836      839       +3     
  Misses        131      131              
Impacted Files Coverage Δ
...edu/ie3/powerFactory2psdm/util/QuantityUtils.scala 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aa66a6...37b8e93. Read the comment docs.

Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking: Is it correct that FixedFeedIn and Transformer2W is still providing sRated in MVA?

@sonarqubegithubprchecks

This comment has been minimized.

@t-ober
Copy link
Contributor Author

t-ober commented Mar 28, 2022

Just checking: Is it correct that FixedFeedIn and Transformer2W is still providing sRated in MVA?

Good catch ! For the FixedFeedIn I should use kVA for the Transformer this is right

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • 100 percent coverage100.00% Coverage (86.50% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:powerFactory2psdm

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quick fix Pv power assignment
2 participants