Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #412
With this PR jsrepo now supports detecting dependencies through the
import(...)
syntax in TypeScript and Svelte files.Previously if you tried to do something like:
In this case
shiki
is resolved correctly but@shiki/langs
and@shiki/themes
are not. Meaning this example will break your users when they install this code.Why only Svelte and Typescript (
.(js|ts|jsx|tsx)
)?Currently with the way that vue structures it's AST it's not very straightforward to walk to get nested nodes. So for the time being this will only work for Svelte and Typescript. If you know of a way to make this work in Vue let me know!